On Fri, Mar 21, 2025 at 9:51 AM Mark Brown broonie@kernel.org wrote:
On Fri, Mar 21, 2025 at 09:01:35AM -0600, Nico Pache wrote:
On Fri, Mar 21, 2025 at 8:51 AM Mark Brown broonie@kernel.org wrote:
That user select should only be visible if KUnit is enabled though, it really is library code so shouldn't actually be user selectable. I'm not sure if there's some other strategy other KUnit tests for libraries use.
I'm a little confused how the FW_CS_DSP config which was added in v5.16 is reliant (library code that is only used by KUNIT) on a config that was added in v6.14. Presumably the library is not just for the KUNIT test. What was the purpose of this config before the introduction of the KUNIT test. Im guessing it was not user selectable back then too.
This is support code for DSPs that Cirrus have in some of their devices, the drivers for devices that have these DSPs select it - a git grep will show the selects.
Ah ok I see! I'm not sure what the 'proper' KUNIT behavior is for this config case. But I'll trust your judgement and expertise, we can probably leave this as is for now.
Cheers, -- Nico