On Mon, Mar 03, 2025 at 12:08:49PM +0000, Lorenzo Stoakes wrote:
On Mon, Mar 03, 2025 at 05:09:21AM +0000, jeffxu@chromium.org wrote:
From: Jeff Xu jeffxu@chromium.org
Add sysmap_is_sealed.c to test system mappings are sealed.
Note: CONFIG_MSEAL_SYSTEM_MAPPINGS must be set, as indicated in config file.
Signed-off-by: Jeff Xu jeffxu@chromium.org
We do need to add this to the general selftests Makefile, but this code is fine, so have a:
Reviewed-by: Lorenzo Stoakes lorenzo.stoakes@oracle.com
Congratulations! :) and thanks for addressing the issues that were raised, appreciate your efforts on this.
Maybe you could send a fix patch? As it's such a small fix.
Cheers, Lorenzo
.../mseal_system_mappings/.gitignore | 2 + .../selftests/mseal_system_mappings/Makefile | 6 + .../selftests/mseal_system_mappings/config | 1 + .../mseal_system_mappings/sysmap_is_sealed.c | 113 ++++++++++++++++++
Can you add this to tools/testing/selftests/Makefile? I _think_ adding:
TARGETS += mm
You mean this, I think?
TARGETS += mseal_system_mappings
(But while we're here, why is "mm" where it is in that Makefile? Everything else is alphabetical?)
-Kees