Re: [PATCH v2 1/2] selftests: bpf: drop duplicate max/min definitions

On 4/8/22 7:36 AM, Geliang Tang wrote:

Drop duplicate macros min() and MAX() definitions in prog_tests, use MIN() or MAX() in sys/param.h instead.

Signed-off-by: Geliang Tang geliang.tang@suse.com

tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 5 ++--- tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c | 7 +++---- tools/testing/selftests/bpf/prog_tests/snprintf.c | 5 ++--- tools/testing/selftests/bpf/prog_tests/tc_redirect.c | 2 +- 4 files changed, 8 insertions(+), 11 deletions(-)

Looks good to me. Thanks for cleaning these up.

Reviewed-by: Shuah Khan skhan@linuxfoundation.org

thanks, -- Shuah