On Fri, May 10, 2024 at 09:50:32PM +0100, Conor Dooley wrote:
On Tue, May 07, 2024 at 06:03:19PM +0100, Conor Dooley wrote:
On Fri, May 03, 2024 at 11:18:21AM -0700, Charlie Jenkins wrote:
All of the supported vendor extensions that have been listed in riscv_isa_vendor_ext_list can be exported through /proc/cpuinfo.
Signed-off-by: Charlie Jenkins charlie@rivosinc.com
This seems fine, thanks for updating this interface :)
Reviewed-by: Conor Dooley conor.dooley@microchip.com
Hmm, actually the automation on patchwork is complaining a bunch about the series, but I think that's mostly false positives except for this patch. The nommu defconfigs are prob the easiest way to reproduce this: /build/tmp.QPMRM3oUNu/arch/riscv/kernel/vendor_extensions.c:41:55: error: 'struct riscv_isa_vendor_ext_data_list' has no member named 'vendor_bitmap' /build/tmp.QPMRM3oUNu/arch/riscv/kernel/vendor_extensions.c:42:60: error: 'struct riscv_isa_vendor_ext_data_list' has no member named 'per_hart_vendor_bitmap'; did you mean 'per_hart_isa_bitmap'? /build/tmp.QPMRM3oUNu/arch/riscv/kernel/vendor_extensions.c:43:60: error: 'struct riscv_isa_vendor_ext_data_list' has no member named 'bitmap_size'
Cheers, Conor.
The false negatives always throw me off. The errors are also offset by one patch. This was actually introduced in the following patch "riscv: Introduce vendor variants of extension helpers" because I accidentally fixed this issue in the patch "riscv: cpufeature: Extract common elements from extension checking" instead of the one it was introduced in.
- Charlie