On 07/02, Taehee Yoo wrote:
The devmem TCP requires the hds-thresh value to be 0, but it doesn't change it automatically. Therefore, make configure_headersplit() sets hds-thresh value to 0.
Signed-off-by: Taehee Yoo ap420073@gmail.com
v2:
- Do not implement configure_hds_thresh().
- Make configure_headersplit() sets hds-thresh to 0.
tools/testing/selftests/drivers/net/hw/ncdevmem.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/drivers/net/hw/ncdevmem.c b/tools/testing/selftests/drivers/net/hw/ncdevmem.c index cc9b40d9c5d5..52b72de11e3b 100644 --- a/tools/testing/selftests/drivers/net/hw/ncdevmem.c +++ b/tools/testing/selftests/drivers/net/hw/ncdevmem.c @@ -331,6 +331,12 @@ static int configure_headersplit(bool on) ret = ethtool_rings_set(ys, req); if (ret < 0) fprintf(stderr, "YNL failed: %s\n", ys->err.msg);
- if (on) {
ethtool_rings_set_req_set_hds_thresh(req, 0);ret = ethtool_rings_set(ys, req);
Why call ethtool_rings_set again here? Can we move ethtool_rings_set_req_set_hds_thresh to be after ethtool_rings_set_req_set_tcp_data_split ?