Re: [PATCH v2 net 1/6] eth: bnxt: fix truesize for mb-xdp-pass case

On Fri, Mar 7, 2025 at 10:35 AM Jakub Kicinski kuba@kernel.org wrote:

Hi Jakub, Thanks a lot for the review!

On Thu, 6 Mar 2025 07:24:17 +0000 Taehee Yoo wrote:

...

• struct skb_shared_info sinfo = {0};
  

...

•         memcpy(&sinfo, xdp_get_shared_info_from_buff(&xdp),
  

•                sizeof(struct skb_shared_info));
  

This may be a little expensive, struct skb_shared_info is 320B and we only really need it in a rare occasion of having multi-buf XDP.

You're right, it's pretty heavy. I didn't think about the total size of the shared_info.

Can we update agg_bufs = sinfo->nr_frags after calling bnxt_rx_xdp(), and otherwise go back to something like you v1?

Okay, I will update agg_bufs with stored sinfo->nr_frags.

Sorry if I mislead you.

It was my intention, no problem :)

Thanks a lot! Taehee Yoo

-- pw-bot: cr