Re: [PATCH v4 7/8] tracing/selftests: Add tests for hist trigger expression parsing

On Tue, 26 Oct 2021 07:28:39 -0700 Kalesh Singh kaleshsingh@google.com wrote:

...

If this update has any meaning, please make a separate patch for this part.

Hi Masami,

Thanks for the feedback. The above change is to ensure we remove triggers in the reverse order that we created them - important when one trigger depends on another. I can split it out into a separate patch and will add a README pattern check to the requires tag for these tests.

Also make sure to run all the ftracetests. When I ran it with this update, most of the other histogram tests failed. Even with your patches applied to the running kernel.

-- Steve