Re: [PATCH v3 4/6] kasan: test: Use NULL macros

On Mon, Feb 7, 2022 at 1:11 PM Ricardo Ribalda ribalda@chromium.org wrote:

Replace PTR_EQ checks with the more idiomatic and specific NULL macros.

Signed-off-by: Ricardo Ribalda ribalda@chromium.org

Acked-by: Daniel Latypov dlatypov@google.com

---

lib/test_kasan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_kasan.c b/lib/test_kasan.c index 847cdbefab46..d680f46740b8 100644 --- a/lib/test_kasan.c +++ b/lib/test_kasan.c @@ -385,7 +385,7 @@ static void krealloc_uaf(struct kunit *test) kfree(ptr1);

    KUNIT_EXPECT_KASAN_FAIL(test, ptr2 = krealloc(ptr1, size2, GFP_KERNEL));

•   KUNIT_ASSERT_PTR_EQ(test, (void *)ptr2, NULL);
  

•   KUNIT_ASSERT_NULL(test, ptr2);
    KUNIT_EXPECT_KASAN_FAIL(test, *(volatile char *)ptr1);
  

}

-- 2.35.0.263.gb82422642f-goog