On 04/02/2023 14:56, Guillaume Tucker wrote:
On some systems, the default echo command doesn't handle the -e option and the output looks like this (arm64 build):
-ne Emit Tests for alsa
-ne Emit Tests for amd-pstate
-ne Emit Tests for arm64
This is for example the case with the KernelCI Docker images e.g. kernelci/gcc-10:x86-kselftest-kernelci. To avoid this issue, use printf which handles escape characters as a standard feature and is more widespread among modern shells.
The output is now formatted as expected (x86 build this time):
Emit Tests for alsa Emit Tests for amd-pstate Skipping non-existent dir: arm64
Reported-by: "kernelci.org bot" bot@kernelci.org Suggested-by: David Laight David.Laight@ACULAB.COM Fixes: 3297a4df805d ("kselftests: Enable the echo command to print newlines in Makefile") Signed-off-by: Guillaume Tucker guillaume.tucker@collabora.com
Notes: v2: use printf insead of $(which echo)
Oh I see you've already applied the v1 on kselftest/next branch:
79c16b1120fe selftests: find echo binary to use -ne options
Do you want me to send this printf fix rebased on top?
Thanks, Guillaume