[ Note, I'm not on the Android team and my response has nothing to do with my employer. I would say the same thing with my previous employer. ]
On Wed, 29 Jun 2022 18:45:43 +0200 Christoph Hellwig hch@lst.de wrote:
On Wed, Jun 29, 2022 at 06:38:09PM +0200, Jason A. Donenfeld wrote:
On the technical topic, an Android developer friend following this thread just pointed out to me that Android doesn't use PM_AUTOSLEEP and just has userspace causing suspend frequently. So by his rough estimation your patch actually *will* break Android devices. Zoinks. Maybe he's right, maybe he's not -- I don't know -- but you should probably look into this if you want this patch to land without breakage.
And it will also "break" anyone else doing frequent suspends from userspace, as that behavior is still in no way related to CONFIG_ANDROID.
Should there then be a CONFIG_FREQUENT_SUSPENDS ?
That is, if you have system where you know that there will be a lot of frequent suspends coming from user space, then you would enable it.
I agree, calling this ANDROID is not related to the functionality change. But if there was a config that was related, would that be acceptable?
Then it would not just be Android that could enabled this change, but any other system that is doing frequent suspends?
-- Steve