Hi David,
I love your patch! Yet something to improve:
[auto build test ERROR on c4d6fe7311762f2e03b3c27ad38df7c40c80cc93]
url: https://github.com/0day-ci/linux/commits/David-Gow/fat-Add-KUnit-tests-for-c... base: c4d6fe7311762f2e03b3c27ad38df7c40c80cc93 config: sparc64-randconfig-r034-20201022 (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/2395aa690e74265a3d09190ff5fc3628dcac... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review David-Gow/fat-Add-KUnit-tests-for-checksums-and-timestamps/20201021-141819 git checkout 2395aa690e74265a3d09190ff5fc3628dcac9f09 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
fs/fat/inode.c:64:35: error: 'CONFIG_FAT_DEFAULT_CODEPAGE' undeclared here (not in a function); did you mean 'CONFIG_FAT_DEFAULT_IOCHARSET'?
64 | static int fat_default_codepage = CONFIG_FAT_DEFAULT_CODEPAGE; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ | CONFIG_FAT_DEFAULT_IOCHARSET
vim +64 fs/fat/inode.c
190a8843ded231 Conrad Meyer 2014-06-06 63 ^1da177e4c3f41 Linus Torvalds 2005-04-16 @64 static int fat_default_codepage = CONFIG_FAT_DEFAULT_CODEPAGE; ^1da177e4c3f41 Linus Torvalds 2005-04-16 65 static char fat_default_iocharset[] = CONFIG_FAT_DEFAULT_IOCHARSET; ^1da177e4c3f41 Linus Torvalds 2005-04-16 66
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org