On Wed, Aug 20, 2025, Sean Christopherson wrote:
On Wed, Aug 20, 2025, Mark Brown wrote:
On Tue, Jun 24, 2025 at 04:19:30PM -0700, Sean Christopherson wrote:
Rename is_signed_type() to is_signed_var() to avoid colliding with a macro of the same name defined by linux/overflow.h. Note, overflow.h's version takes a type as the input, whereas the harness's version takes a variable!
This patch is in -next and is causing widespread breakage in the selftests -next on at least arm and arm64 due to:
make --silent --keep-going --jobs=15 O=/build/stage/build-work INSTALL_PATH=/build/stage/build-work/kselftest_install ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CROSS_COMPILE_COMPAT=arm-linux-gnueabihf- kselftest-install
...
In file included from test-pcmtest-driver.c:10: ../kselftest_harness.h:59:10: fatal error: linux/overflow.h: No such file or directory 59 | #include <linux/overflow.h> | ^~~~~~~~~~~~~~~~~~ compilation terminated.
Argh, many selftests don't add tools/include to their include path. The least awful thing I can think of is to go with a minimal fix to avoid the collision. AFAICT, nothing outside of kselftest_harness.h uses is_signed_type(), so this shouldn't cause a different flavor of breakage?
I force-pushed a straight rename. Please holler if that somehow still breaks builds.
[1/1] selftests: harness: Rename is_signed_type() to avoid collision with overflow.h https://github.com/kvm-x86/linux/commit/dce1b33ed743