Hi Alan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on linux/master v5.5-rc2 next-20191218] [cannot apply to ext4/dev] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Alan-Maguire/kunit-support-building... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b0d4beaa5a4b7d31070c41c2e50740304a3f1138 config: x86_64-randconfig-e002-20191218 (attached as .config) compiler: gcc-7 (Debian 7.5.0-1) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64
If you fix the issue, kindly add following tag Reported-by: kbuild test robot lkp@intel.com
All errors (new ones prefixed by >>):
drivers/base/power/qos-test.c:117:1: warning: data definition has no type or storage class kunit_test_suite(pm_qos_test_module); ^~~~~~~~~~~~~~~~
drivers/base/power/qos-test.c:117:1: error: type defaults to 'int' in declaration of 'kunit_test_suite' [-Werror=implicit-int]
drivers/base/power/qos-test.c:117:1: warning: parameter names (without types) in function declaration drivers/base/power/qos-test.c:113:27: warning: 'pm_qos_test_module' defined but not used [-Wunused-variable] static struct kunit_suite pm_qos_test_module = { ^~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors
vim +117 drivers/base/power/qos-test.c
14e087576081f4 Leonard Crestez 2019-11-26 112 14e087576081f4 Leonard Crestez 2019-11-26 113 static struct kunit_suite pm_qos_test_module = { 14e087576081f4 Leonard Crestez 2019-11-26 114 .name = "qos-kunit-test", 14e087576081f4 Leonard Crestez 2019-11-26 115 .test_cases = pm_qos_test_cases, 14e087576081f4 Leonard Crestez 2019-11-26 116 }; 14e087576081f4 Leonard Crestez 2019-11-26 @117 kunit_test_suite(pm_qos_test_module);
:::::: The code at line 117 was first introduced by commit :::::: 14e087576081f4f3a6fc6a229166b05b65cf98e5 PM / QoS: Initial kunit test
:::::: TO: Leonard Crestez leonard.crestez@nxp.com :::::: CC: Rafael J. Wysocki rafael.j.wysocki@intel.com
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation