On Mon, 26 Oct 2020 at 19:36, Arpitha Raghunandan 98.arpi@gmail.com wrote: [...]
* success starts as true, and may only be set to false during a * test case; thus, it is safe to update this across multiple@@ -1742,4 +1760,18 @@ do { \ fmt, \ ##__VA_ARGS__)
+/**
- KUNIT_PARAM_GENERATOR() - Helper method for test parameter generators
required in parameterized tests.
- @name: prefix of the name for the test parameter generator function.
This could mention that the generator function will be suffixed by "_gen_params".
- @prev: a pointer to the previous test parameter, NULL for first parameter.
- @array: a user-supplied pointer to an array of test parameters.
- */
I just noticed this: the interface of this macro does not include "prev" (which is an argument of the generated function, but not supplied to this macro; "prev" should hopefully be explained in the other comment you're adding for the new struct field). So, the kernel-doc comment here should only list the actual arguments of this macro, which is only "name" and "array".
+#define KUNIT_PARAM_GENERATOR(name, array) \
[...]
Thanks, -- Marco