On 12/21/23 13:49, Antonio Terceiro wrote:
This makes the uevent selftests build not write to the source tree unconditionally, as that breaks out of tree builds when the source tree is read-only. It also avoids leaving a git repository in a dirty state after a build.
Why can't you do that using make O= directive.
v2: drop spurious extra SPDX-License-Identifier
Signed-off-by: Antonio Terceiro antonio.terceiro@linaro.org
tools/testing/selftests/uevent/Makefile | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/tools/testing/selftests/uevent/Makefile b/tools/testing/selftests/uevent/Makefile index f7baa9aa2932..872969f42694 100644 --- a/tools/testing/selftests/uevent/Makefile +++ b/tools/testing/selftests/uevent/Makefile @@ -1,17 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 all: -include ../lib.mk
-.PHONY: all clean
-BINARIES := uevent_filtering -CFLAGS += -Wl,-no-as-needed -Wall +CFLAGS += -Wl,-no-as-needed -Wall $(KHDR_INCLUDES) -uevent_filtering: uevent_filtering.c ../kselftest.h ../kselftest_harness.h
- $(CC) $(CFLAGS) $< -o $@
+TEST_GEN_PROGS = uevent_filtering -TEST_PROGS += $(BINARIES) -EXTRA_CLEAN := $(BINARIES)
-all: $(BINARIES) +include ../lib.mk
This change doesn't get the intended result of not writing to source tree. Binaries will still be written to the source tree unless O= is specified.
thanks, -- Shuah