On Sun, May 5, 2024 at 6:21 AM David Laight David.Laight@aculab.com wrote:
From: Justin Stitt
Sent: 01 May 2024 20:55
...
static unsigned long elf_hash(const unsigned char *name)
...
Is it possible to just change the types of the parameters of vdso_sym() or does that trigger even more warnings on the callsites of vdso_sym()?
Isn't the problem the definition of elf_hash()? A '\0' terminated string really ought to be 'char *' not 'unsigned char *'.
Right, although note this comment just about its definition:
/* Straight from the ELF specification. */ static unsigned long elf_hash(const unsigned char *name) {
which indeed matches [1]
[1]: https://man.freebsd.org/cgi/man.cgi?query=elf_hash&sektion=3&apropos...
David
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)