Re: [PATCH v17 07/19] kunit: test: add initial tests

On 9/20/19 5:18 PM, Brendan Higgins wrote:

Add a test for string stream along with a simpler example.

Signed-off-by: Brendan Higgins brendanhiggins@google.com Reviewed-by: Greg Kroah-Hartman gregkh@linuxfoundation.org Reviewed-by: Logan Gunthorpe logang@deltatee.com Reviewed-by: Stephen Boyd sboyd@kernel.org

---

lib/kunit/Kconfig | 25 ++++++++++ lib/kunit/Makefile | 4 ++ lib/kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++ lib/kunit/string-stream-test.c | 52 ++++++++++++++++++++ 4 files changed, 169 insertions(+) create mode 100644 lib/kunit/example-test.c create mode 100644 lib/kunit/string-stream-test.c

diff --git a/lib/kunit/Kconfig b/lib/kunit/Kconfig index 666b9cb67a74..3868c226cf31 100644 --- a/lib/kunit/Kconfig +++ b/lib/kunit/Kconfig @@ -11,3 +11,28 @@ menuconfig KUNIT special hardware when using UML. Can also be used on most other architectures. For more information, please see Documentation/dev-tools/kunit/.

+if KUNIT

The 'if' above provides the dependency clause, so the 2 'depends on KUNIT' below are not needed. They are redundant.

+config KUNIT_TEST

• bool "KUnit test for KUnit"
• depends on KUNIT
• help

•  Enables the unit tests for the KUnit test framework. These tests test
  

•  the KUnit test framework itself; the tests are both written using
  

•  KUnit and test KUnit. This option should only be enabled for testing
  

•  purposes by developers interested in testing that KUnit works as
  

•  expected.
  

+config KUNIT_EXAMPLE_TEST

• bool "Example test for KUnit"
• depends on KUNIT
• help

•  Enables an example unit test that illustrates some of the basic
  

•  features of KUnit. This test only exists to help new users understand
  

•  what KUnit is and how it is used. Please refer to the example test
  

•  itself, lib/kunit/example-test.c, for more information. This option
  

•  is intended for curious hackers who would like to understand how to
  

•  use KUnit for kernel development.
  

+endif # KUNIT