Re: [PATCHv2 net-next 1/3] bonding: add support for per-port LACP actor priority

18 Aug 2025


      On Thu, Aug 14, 2025 at 01:46:10PM +0200, Jonas Gorski wrote:
...
...
@@ -77,6 +78,10 @@ static int bond_fill_slave_info(struct sk_buff *skb,
   				ad_port->partner_oper.port_state))
   			goto nla_put_failure;
   	}


if (nla_put_u16(skb, IFLA_BOND_SLAVE_AD_ACTOR_PORT_PRIO,


		SLAVE_AD_INFO(slave)->port_priority))


	goto nla_put_failure;



This is an 802.3ad (exclusive) setting, shouldn't this be in the
if (BOND_MODE(slave->bond) == BOND_MODE_8023AD) { }
block above this?
Oh, just notice the change is already in the block. The code looks like
if (BOND_MODE(slave->bond) == BOND_MODE_8023AD) {
    	if (agg) {
    	}
if (nla_put_u16(skb, IFLA_BOND_SLAVE_AD_ACTOR_PORT_PRIO, ...)
    		goto nla_put_failure;
    }
Thanks
Hangbin

    