Re: [RFC PATCH v3 04/12] netdev: support binding dma-buf to netdevice

On 2023/11/6 10:44, Mina Almasry wrote:

+void __netdev_devmem_binding_free(struct netdev_dmabuf_binding *binding) +{

• size_t size, avail;
• gen_pool_for_each_chunk(binding->chunk_pool,

• 		netdev_devmem_free_chunk_owner, NULL);
  

• size = gen_pool_size(binding->chunk_pool);
• avail = gen_pool_avail(binding->chunk_pool);
• if (!WARN(size != avail, "can't destroy genpool. size=%lu, avail=%lu",

•   size, avail))
  

• gen_pool_destroy(binding->chunk_pool);
  

Is there any other place calling the gen_pool_destroy() when the above warning is triggered? Do we have a leaking for binding->chunk_pool?

• dma_buf_unmap_attachment(binding->attachment, binding->sgt,

• 		 DMA_BIDIRECTIONAL);
  

• dma_buf_detach(binding->dmabuf, binding->attachment);
• dma_buf_put(binding->dmabuf);
• kfree(binding);

+}