Hi Sagi,
On 10/28/25 2:20 PM, Sagi Shahar wrote:
From: Isaku Yamahata isaku.yamahata@intel.com
Let kvm_init_vm_address_properties() initialize vm->arch.{s_bit, tag_mask} similar to SEV.
To me this seems like a verbatim description of what can be seen from the patch self. How about something like: Initialize which GPA bit a TDX VM uses to tag shared memory in guest page tables.
TDX sets the shared bit based on the guest physical address width and currently supports 48 and 52 widths.
...
diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h new file mode 100644 index 000000000000..286d5e3c24b1 --- /dev/null +++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef SELFTESTS_TDX_TDX_UTIL_H +#define SELFTESTS_TDX_TDX_UTIL_H
+#include <stdbool.h>
+#include "kvm_util.h"
+static inline bool is_tdx_vm(struct kvm_vm *vm) +{
- return vm->type == KVM_X86_TDX_VM;
+}
+#endif // SELFTESTS_TDX_TDX_UTIL_H
I recommend this work sticks to using /* ... */ for single line comments. For reference you can compare the custom of all the other header files in this area.
Reinette