On Mon, Aug 11, 2025 at 09:33:28AM -0700, Jakub Kicinski wrote:
On Mon, 11 Aug 2025 07:27:19 -0700 Jay Vosburgh wrote:
Generically, I'm wondering if test updates should be separate patches from the functional changes as a general policy.
Yes, not sure if we made it a hard requirement, but I think it's our preference. It is the reason why we don't require cover letters for submissions with 2 patches.
Hangbin, please update config for bonding tests, looks like vlans are not enabled there today.
BTW, I'd like to change the bond config to modules. Because we can't unload the modules with current config. It that OK for you?
diff --git a/tools/testing/selftests/drivers/net/bonding/config b/tools/testing/selftests/drivers/net/bonding/config index dad4e5fda4db..858ba0f19348 100644 --- a/tools/testing/selftests/drivers/net/bonding/config +++ b/tools/testing/selftests/drivers/net/bonding/config @@ -1,11 +1,11 @@ -CONFIG_BONDING=y -CONFIG_BRIDGE=y -CONFIG_DUMMY=y +CONFIG_BONDING=m +CONFIG_BRIDGE=m +CONFIG_DUMMY=m CONFIG_IPV6=y -CONFIG_MACVLAN=y -CONFIG_IPVLAN=y -CONFIG_NET_ACT_GACT=y -CONFIG_NET_CLS_FLOWER=y -CONFIG_NET_SCH_INGRESS=y -CONFIG_NLMON=y -CONFIG_VETH=y +CONFIG_MACVLAN=m +CONFIG_IPVLAN=m +CONFIG_NET_ACT_GACT=m +CONFIG_NET_CLS_FLOWER=m +CONFIG_NET_SCH_INGRESS=m +CONFIG_NLMON=m +CONFIG_VETH=m
Thanks Hangbin