Hi Leon, Shuah,
Thanks for the fix. I had this issue pending to fix, but have been lazy about it, I appreciate you are taking care of it!
On Sat, 7 Mar 2020 at 11:03, Leon He hexiaolong2008@gmail.com wrote:
From: Leon He leon.he@unisoc.com
There are two errors in the dmabuf-heap selftest:
- The 'char name[5]' was not initialized to zero, which will cause strcmp(name, "vgem") failed in check_vgem().
- The return value of test_alloc_errors() should be reversed, other- wise the while loop in main() will be broken.
Signed-off-by: Leon He leon.he@unisoc.com
tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c index cd5e1f6..836b185 100644 --- a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c +++ b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c @@ -22,7 +22,7 @@ static int check_vgem(int fd) { drm_version_t version = { 0 };
char name[5];
char name[5] = { 0 }; int ret;
As Shuah already mentioned, I think we want to use strncmp to be on the safe side.
version.name_len = 4;@@ -357,7 +357,7 @@ static int test_alloc_errors(char *heap_name) if (heap_fd >= 0) close(heap_fd);
return ret;
return !ret;
I agree with Shuah, this change makes no sense, just drop it.
I think the fact this test was broken and nobody noticed uncovers the fact that the test isn't being run.
Any reason why this test isn't a regular TARGET? Or any idea how we can make sure this is run by CIs and any other testing system?
Thanks! Ezequiel
}
int main(void)
2.7.4