On 12. 07. 24 20:19, Mark Brown wrote:
On Fri, Jul 12, 2024 at 06:25:21PM +0200, Jaroslav Kysela wrote:
On 12. 07. 24 15:00, Mark Brown wrote:
The trouble with the ID field is that it's too short and seems likely to create collisions, for example HDA stuff just seems to default to NVidia for nVidia cards which seems very likely to create collisions if someone has two graphics cards in their system.
The default IDs are always unique - see snd_card_set_id_no_lock() in sound/core/init.c . Basically, the suffix will follow the device probe order in this case.
Sure, but the genesis of this patch is that probe order isn't sufficiently stable and we want to avoid names based on it... using the ID will be more likely to work out stable than just pure probe order but it's still got the same issue.
The probe order is almost stable for the drivers with the non-deferred probe. Also, administrators may set persistent ID for complex hardware configuration cases based on other keys like serial number or so (sysfs/udev).
For long name - the device path may change (USB moved to different port, PCI card moved to different slot), so the stability of this string is also questionable.
Jaroslav