Re: [PATCH v2] selftests: ublk: fix behavior when fio is not installed

On Tue, Sep 16, 2025 at 06:42:52PM -0600, Uday Shankar wrote:

Some ublk selftests have strange behavior when fio is not installed. While most tests behave correctly (run if they don't need fio, or skip if they need fio), the following tests have different behavior:

• test_null_01, test_null_02, test_generic_01, test_generic_02, and test_generic_12 try to run fio without checking if it exists first, and fail on any failure of the fio command (including "fio command not found"). So these tests fail when they should skip.
• test_stress_05 runs fio without checking if it exists first, but doesn't fail on fio command failure. This test passes, but that pass is misleading as the test doesn't do anything useful without fio installed. So this test passes when it should skip.

Fix these issues by adding _have_program fio checks to the top of all of these tests.

Signed-off-by: Uday Shankar ushankar@purestorage.com

Changes in v2:

• Also fix test_generic_01, test_generic_02, test_generic_12, which fail on systems where bpftrace is installed but fio is not (Mohit Gupta)
• Link to v1: https://lore.kernel.org/r/20250916-ublk_fio-v1-1-8d522539eed7@purestorage.co...

Reviewed-by: Ming Lei ming.lei@redhat.com

Thanks, Ming