5 Jan
2026
5 Jan
'26
5 p.m.
Hi Mark,
On 1/5/26 16:45, Mark Brown wrote:
On Fri, Jan 02, 2026 at 02:50:07PM +0000, Ben Horgan wrote:
On 12/19/25 19:28, Mark Brown wrote:
if (aarch64_only && sys_reg_CRm(reg_id) < 4) {ksft_test_result_skip("%s value seen in guest\n",get_reg_name(reg_id));break;}Unnecessary? The decision for which regs are testing is made in guest_code().
The guest code has a fixed list of registers it reads blindly and we skip the write for these so our expected value won't be something we explicitly set. The actual test is done here in the host code and it seems both more maintainable to keep the skip adjacent to the live test and clearer to be more explicit about nothing actually being tested.
Thanks for the explanation, it seems like a sensible decision.
Ben