17 Dec
2025
17 Dec
'25
2:36 a.m.
Hi Reinette,
On 12/17/2025 7:26 AM, Reinette Chatre wrote:
-static int detect_vendor(void) +static unsigned int detect_vendor(void) {
- FILE *inf = fopen("/proc/cpuinfo", "r");
- int vendor_id = 0;
- FILE *inf;
- static unsigned int vendor_id; char *s = NULL; char *res;
- static bool initialized;
The changelog incorrectly claims that this should now match reverse fir ordering. To be "reverse fir" ordered the declarations should look like:
static unsigned int vendor_id; static bool initialized; char *s = NULL; FILE *inf; char *res;
Thank you! I will fix it on v5 patch.
With this fixed: | Reviewed-by: Reinette Chatre reinette.chatre@intel.com
Thank you!
Best regards, Xiaochen Shen