On Sat, 2 Aug 2025 at 11:45, David Gow davidgow@google.com wrote:
On Wed, 30 Jul 2025 at 03:37, Marie Zhussupova marievic@google.com wrote:
This patch modifies `nthreads_gen_params` in kcsan_test.c to accept an additional `struct kunit *test` argument.
Signed-off-by: Marie Zhussupova marievic@google.com
This is a pretty straightforward fix after patch 3. KCSAN folks, would you prefer this kept as a separate patch, or squashed into the previous one (so there's no commit where this is broken)?
Normally patch series should be structured so that bisection does not break. Having this fixup as a separate patch means that bisections where the KCSAN test is enabled will break.
This is a tiny change, so I'd just squash it.
Either way, Reviewed-by: David Gow davidgow@google.com
-- David
kernel/kcsan/kcsan_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kcsan/kcsan_test.c b/kernel/kcsan/kcsan_test.c index c2871180edcc..fc76648525ac 100644 --- a/kernel/kcsan/kcsan_test.c +++ b/kernel/kcsan/kcsan_test.c @@ -1383,7 +1383,7 @@ static void test_atomic_builtins_missing_barrier(struct kunit *test)
- The thread counts are chosen to cover potentially interesting boundaries and
- corner cases (2 to 5), and then stress the system with larger counts.
*/ -static const void *nthreads_gen_params(const void *prev, char *desc) +static const void *nthreads_gen_params(struct kunit *test, const void *prev, char *desc) { long nthreads = (long)prev;
-- 2.50.1.552.g942d659e1b-goog