On tor, jun 02, 2022 at 13:39, Ido Schimmel idosch@nvidia.com wrote:
On Thu, Jun 02, 2022 at 01:30:06PM +0300, Nikolay Aleksandrov wrote:
On 02/06/2022 13:17, Hans Schultz wrote:
On tor, jun 02, 2022 at 12:33, Nikolay Aleksandrov razor@blackwall.org wrote:
On 02/06/2022 12:17, Hans Schultz wrote:
On tis, maj 31, 2022 at 17:23, Ido Schimmel idosch@nvidia.com wrote:
On Tue, May 31, 2022 at 11:34:21AM +0200, Hans Schultz wrote:
Another issue is that bridge fdb add MAC dev DEV master static seems to add the entry with the SELF flag set, which I don't think is what we would want it to do or?
I don't see such thing (hacked iproute2 to print the flags before cmd): $ bridge fdb add 00:11:22:33:44:55 dev vnet110 master static flags 0x4
0x4 = NTF_MASTER only
I also get 0x4 from iproute2, but I still get SELF entries when I look with: bridge fdb show dev DEV
after the above add: $ bridge fdb show dev vnet110 | grep 00:11 00:11:22:33:44:55 master virbr0 static
I think Hans is testing with mv88e6xxx which dumps entries directly from HW via ndo_fdb_dump(). See dsa_slave_port_fdb_do_dump() which sets NTF_SELF.
Hans, are you seeing the entry twice? Once with 'master' and once with 'self'?
Well yes, but I get some additional entries with 'self' for different vlans. So from clean adding a random fdb entry I get 4 entries on the port, 2 with 'master' and two with 'self'. It looks like this:
# bridge fdb add 00:22:33:44:55:66 dev eth6 master static # bridge fdb show dev eth6 | grep 55 00:22:33:44:55:66 vlan 1 master br0 offload static 00:22:33:44:55:66 master br0 offload static 00:22:33:44:55:66 vlan 1 self static 00:22:33:44:55:66 vlan 4095 self static
If I do a replace of a locked entry I only get one with the 'self' flag.