On Wed, Oct 09, 2024 at 12:28:03PM +0100, Mark Brown wrote:
On Tue, Oct 08, 2024 at 03:36:48PM -0700, Deepak Gupta wrote:
riscv will need an implementation for exit_thread to clean up shadow stack when thread exits. If current thread had shadow stack enabled, shadow stack is allocated by default for any new thread.
FWIW both arm64 and x86 do this via deactivate_mm(). ISTR there's some case where exit_thread() doesn't quite do the right thing but I can't remember the specifics right now, possibly the vfork() case but ICBW? In any case like Rick said factoring out the common patterns would be good, keeping things aligned would support that.
Now getting back to collecting feedback and sending another version. Yeah I found what you meant. https://lore.kernel.org/all/20230908203655.543765-1-rick.p.edgecombe@intel.c...
Seems like an issue for riscv as well. Will fix it. This particular issue screaming out loud for converging flows as well.