On Tue, Jul 21, 2020 at 6:26 PM Willem de Bruijn willemdebruijn.kernel@gmail.com wrote:
Fixes: cda261f421ba ("selftests: add txtimestamp kselftest")
Acked-by: Willem de Bruijn willemb@google.com
Besides, is it just me or this test fails frequently? I've been running it on 5.4.x, 5.7.x and 5.8-rcX and it often fails:
... USR: 1595405084 s 947366 us (seq=0, len=0) SND: 1595405084 s 948686 us (seq=9, len=10) (USR +1319 us) ERROR: 6542 us expected between 6000 and 6500 ACK: 1595405084 s 953908 us (seq=9, len=10) (USR +6541 us) USR: 1595405084 s 997979 us (seq=0, len=0) SND: 1595405084 s 999101 us (seq=19, len=10) (USR +1121 us) ACK: 1595405085 s 4438 us (seq=19, len=10) (USR +6458 us) USR: 1595405085 s 49317 us (seq=0, len=0) SND: 1595405085 s 50680 us (seq=29, len=10) (USR +1363 us) ERROR: 6661 us expected between 6000 and 6500 ACK: 1595405085 s 55978 us (seq=29, len=10) (USR +6661 us) USR: 1595405085 s 101049 us (seq=0, len=0) SND: 1595405085 s 102342 us (seq=39, len=10) (USR +1293 us) ERROR: 6578 us expected between 6000 and 6500 ACK: 1595405085 s 107627 us (seq=39, len=10) (USR +6577 us) USR-SND: count=4, avg=1274 us, min=1121 us, max=1363 us USR-ACK: count=4, avg=6559 us, min=6458 us, max=6661 us
In particular, "run_test_v4v6 ${args} # tcp" is the most susceptible to failures (though i've seen the udp variant fail too).