15 Nov
2020
15 Nov
'20
8:45 a.m.
On Sun, Nov 15, 2020 at 12:11:15AM +0000, Song Bao Hua (Barry Song) wrote:
Checkpatch has changed 80 to 100. That's probably why my local checkpatch didn't report any warning: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...
I am happy to change them to be less than 80 if you like.
Don't rely on checkpath, is is broken. Look at the codingstyle document.
I think this needs to set a dma mask as behavior for unlimited dma mask vs the default 32-bit one can be very different.
I actually prefer users bind real devices with real dma_mask to test rather than force to change the dma_mask in this benchmark.
The mask is set by the driver, not the device. So you need to set when when you bind, real device or not.