On Wed, Feb 5, 2020 at 2:08 PM Mike Kravetz mike.kravetz@oracle.com wrote:
On 2/3/20 3:22 PM, Mina Almasry wrote:
Augments hugetlb_cgroup_charge_cgroup to be able to charge hugetlb usage or hugetlb reservation counter.
Adds a new interface to uncharge a hugetlb_cgroup counter via hugetlb_cgroup_uncharge_counter.
Integrates the counter with hugetlb_cgroup, via hugetlb_cgroup_init, hugetlb_cgroup_have_usage, and hugetlb_cgroup_css_offline.
Signed-off-by: Mina Almasry almasrymina@google.com Acked-by: Mike Kravetz mike.kravetz@oracle.com Acked-by: David Rientjes rientjes@google.com
Changes in v11:
- Changed all 'reserved' or 'reservation' to 'rsvd' to reflect the user
interface.
Thanks.
Small nit,
@@ -450,8 +496,7 @@ static ssize_t hugetlb_cgroup_reset(struct kernfs_open_file *of, struct hugetlb_cgroup *h_cg = hugetlb_cgroup_from_css(of_css(of));
counter = &h_cg->hugepage[MEMFILE_IDX(of_cft(of)->private)];
rsvd_counter =&h_cg->rsvd_hugepage[MEMFILE_IDX(of_cft(of)->private)];
rsvd_counter = &h_cg->rsvd_hugepage[MEMFILE_IDX(of_cft(of)->private)];That looks like a change just to reformat a line added in the first patch?
switch (MEMFILE_ATTR(of_cft(of)->private)) { case RES_MAX_USAGE:
Gah, my bad. I'll move this to patch 1.
-- Mike Kravetz