Hi Sagi,
typo in subject: definitons -> definitions
On 10/28/25 2:20 PM, Sagi Shahar wrote:
Move kernel segment definitions to a separate file which can be included from assembly files.
Reviewed-by: Ira Weiny ira.weiny@intel.com Reviewed-by: Binbin Wu binbin.wu@linux.intel.com Signed-off-by: Sagi Shahar sagis@google.com
.../selftests/kvm/include/x86/processor_asm.h | 12 ++++++++++++ tools/testing/selftests/kvm/lib/x86/processor.c | 5 +---- 2 files changed, 13 insertions(+), 4 deletions(-) create mode 100644 tools/testing/selftests/kvm/include/x86/processor_asm.h
diff --git a/tools/testing/selftests/kvm/include/x86/processor_asm.h b/tools/testing/selftests/kvm/include/x86/processor_asm.h new file mode 100644 index 000000000000..7e5386a85ca8 --- /dev/null +++ b/tools/testing/selftests/kvm/include/x86/processor_asm.h @@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/*
- Used for storing defines used by both processor.c and assembly code.
I recommend replacing "processor.c" with "c" ... having filenames in headers become stale quite fast. "Used for storing" could also be dropped to keep it brief.
- */
+#ifndef SELFTEST_KVM_PROCESSOR_ASM_H +#define SELFTEST_KVM_PROCESSOR_ASM_H
+#define KERNEL_CS 0x8 +#define KERNEL_DS 0x10 +#define KERNEL_TSS 0x18
+#endif // SELFTEST_KVM_PROCESSOR_ASM_H
(use /* ... */ ... please consider for whole series.)
Reinette