Re: [PATCH v6 08/25] iommufd/viommu: Add driver-defined vDEVICE support

On Thu, Jun 19, 2025 at 08:44:25AM -0300, Jason Gunthorpe wrote:

On Thu, Jun 19, 2025 at 10:26:28AM +0000, Pranjal Shrivastava wrote:

...

...

+struct iommufd_vdevice {

• struct iommufd_object obj;
• struct iommufd_viommu *viommu;
• struct device *dev;
• u64 id; /* per-vIOMMU virtual ID */

Nit: Why not call this viommu_id?

And lets have a comment here too, we have so many different ids, what id is this id and what it is used for, by who.

Sure. Will change to "virt_id" and add some description here.

Thanks Nicolin