Re: [PATCH net-next v15 02/14] net: netdev netlink api to bind dma-buf to a net device

Mina Almasry almasrymina@google.com writes:

• name: bind-dmabuf
• attributes:

•  -
  

•    name: ifindex
  

•    doc: netdev ifindex to bind the dma-buf to.
  

Minor nit:

The series uses a mix of dmabuf and dma-buf but the doc additions (devmem.rst) consistently uses dmabuf. I think it would be helpful to be consistent here and say 'devmem dmabuf' in the docstring to highlight whos dmabuf it is and keep the generated netdev docs in alignment.

•    type: u32
  

•    checks:
  

•      min: 1
  

•  -
  

•    name: queues
  

•    doc: receive queues to bind the dma-buf to.
  

And here.

•    type: nest
  

•    nested-attributes: queue-dmabuf
  

•    multi-attr: true
  

•  -
  

•    name: dmabuf-fd
  

•    doc: dmabuf file descriptor to bind.
  

•    type: u32
  

•  -
  

•    name: dmabuf-id
  

•    doc: id of the dmabuf binding
  

•    type: u32
  

•    checks:
  

•      min: 1
  

• name: qstats

@@ -579,6 +618,20 @@ operations: attributes: - ifindex reply: *queue-get-op

•  name: bind-rx
  

•  doc: Bind dmabuf to netdev
  

And here.

•  attribute-set: bind-dmabuf
  

•  flags: [ admin-perm ]
  

•  do:
  

•    request:
  

•      attributes:
  

•        - ifindex
  

•        - dmabuf-fd
  

•        - queues
  

•    reply:
  

•      attributes:
  

•        - dmabuf-id