Re: [PATCH 1/3] libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value

On 19.09.22 19:24, Akinobu Mita wrote:

The simple attribute files do not accept a negative value since the commit 488dac0c9237 ("libfs: fix error cast of negative value in simple_attr_write()"), so we have to use a 64-bit value to write a negative value.

This adds DEFINE_SIMPLE_ATTRIBUTE_SIGNED for a signed value.

Fixes: 488dac0c9237 ("libfs: fix error cast of negative value in simple_attr_write()")

This patch itself isn't a fix. The fixes tags belong to the other patches that make use of this.

Reported-by: Zhao Gongyi zhaogongyi@huawei.com Signed-off-by: Akinobu Mita akinobu.mita@gmail.com

---

Reviewed-by: David Hildenbrand david@redhat.com