Re: [PATCH 4/5] tools: selftests: riscv: Fix compile warnings in vector tests

On 23/11/2023 19:58, Christoph Muellner wrote:

From: Christoph Müllner christoph.muellner@vrull.eu

GCC prints a couple of format string warnings when compiling the vector tests. Let's follow the recommendation in Documentation/printk-formats.txt to fix these warnings.

Signed-off-by: Christoph Müllner christoph.muellner@vrull.eu

tools/testing/selftests/riscv/vector/v_initval_nolibc.c | 2 +- tools/testing/selftests/riscv/vector/vstate_prctl.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/riscv/vector/v_initval_nolibc.c b/tools/testing/selftests/riscv/vector/v_initval_nolibc.c index 66764edb0d52..1dd94197da30 100644 --- a/tools/testing/selftests/riscv/vector/v_initval_nolibc.c +++ b/tools/testing/selftests/riscv/vector/v_initval_nolibc.c @@ -27,7 +27,7 @@ int main(void) datap = malloc(MAX_VSIZE); if (!datap) {

• ksft_test_result_fail("fail to allocate memory for size = %lu\n", MAX_VSIZE);
  

• ksft_test_result_fail("fail to allocate memory for size = %d\n", MAX_VSIZE);
  

  exit(-1); }

diff --git a/tools/testing/selftests/riscv/vector/vstate_prctl.c b/tools/testing/selftests/riscv/vector/vstate_prctl.c index b348b475be57..8ad94e08ff4d 100644 --- a/tools/testing/selftests/riscv/vector/vstate_prctl.c +++ b/tools/testing/selftests/riscv/vector/vstate_prctl.c @@ -68,7 +68,7 @@ int test_and_compare_child(long provided, long expected, int inherit) } rc = launch_test(inherit); if (rc != expected) {

• ksft_test_result_fail("Test failed, check %d != %d\n", rc,
  

• ksft_test_result_fail("Test failed, check %d != %ld\n", rc,
  	      expected);
  

  return -2; }

@@ -87,7 +87,7 @@ int main(void) pair.key = RISCV_HWPROBE_KEY_IMA_EXT_0; rc = riscv_hwprobe(&pair, 1, 0, NULL, 0); if (rc < 0) {

• ksft_test_result_fail("hwprobe() failed with %d\n", rc);
  

• ksft_test_result_fail("hwprobe() failed with %ld\n", rc);
  

  return -1; }

You can add:

Reviewed-by: Alexandre Ghiti alexghiti@rivosinc.com

Thanks!

Alex