Re: [PATCH v2] kunit: fix failure to build without printk

On (08/28/19 02:31), Brendan Higgins wrote: [..]

Previously KUnit assumed that printk would always be present, which is not a valid assumption to make. Fix that by removing call to vprintk_emit, and calling printk directly.

Reported-by: Randy Dunlap rdunlap@infradead.org Link: https://lore.kernel.org/linux-kselftest/0352fae9-564f-4a97-715a-fabe016259df... Cc: Stephen Rothwell sfr@canb.auug.org.au Cc: Sergey Senozhatsky sergey.senozhatsky.work@gmail.com Signed-off-by: Brendan Higgins brendanhiggins@google.com

[..]

-static void kunit_vprintk(const struct kunit *test,

• 	  const char *level,
  

• 	  struct va_format *vaf)
  

-{

• kunit_printk_emit(level[1] - '0', "\t# %s: %pV", test->name, vaf);

-}

This patch looks good to me. I like the removal of recursive vsprintf() (%pV).

-ss