On Mon, Nov 16, 2020 at 6:40 PM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
On Mon, Nov 16, 2020 at 11:53:09AM +0200, Andy Shevchenko wrote:
On Thu, Nov 12, 2020 at 07:10:25PM -0800, Andrew Morton wrote:
On Thu, 12 Nov 2020 20:07:32 +0200 Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
Test get_option() for a starter which is provided by cmdline.c.
...
lib/cmdline_kunit.c | 98 +++++++++++++++++++++++++++++++++++++++++++++
First of all, thanks for taking care of this!
The spectacular warning storm which this produces makes me wonder if you sent the correct version? I mean, the cmdline_test_values[] definition wasn't even close.
This now puzzles me, what happened. I will check my branches, because certainly I was not only compiled that, but actually run those test cases.
David, Brendan, can we somehow make those warnings visible when run test suite via kunit Python wrapper?
There's a patch in the kunit-fixes branch which should fix this this: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/co...
It seems to me that I run test cases only via wrapper and I have got no warnings which are ones that must be fixed before submission. It's actual disadvantage of the framework (use of it via wrapper) that makes me feel like I would rather not hurry up with KUnit.
Yeah: it's a pain, and I've been hit by it a couple of times recently, too. If you're not able to pick up the changes in the kunit-fixes branch above, then it's definitely best to also manually build a kernel to get the build logs.
In any case, that fix should be merged for 5.10.
Sorry for the inconvenience! -- David