RE: [PATCH v4 4/4] iommufd/selftest: Add coverage for IOMMU_GET_HW_INFO ioctl

From: Nicolin Chen nicolinc@nvidia.com Sent: Thursday, July 27, 2023 4:38 PM

...

...

+TEST_F(iommufd_ioas, get_hw_info) +{

• struct iommu_test_hw_info info;
  

• if (self->device_id) {
  

•         test_cmd_get_hw_info(self->device_id, sizeof(info), &info);
  

•         assert(info.test_reg ==
  

IOMMU_HW_INFO_SELFTEST_REGVAL);

• } else {
  

•         test_err_get_hw_info(ENOENT, self->device_id,
  

•                              sizeof(info), &info);
  

• }
  

If self->device_id is invalid it should be reported right after test_cmd_mock_domain()?

A device_id is created per mock_domain. And mock_domain is a variant that could be 0, so a device_id being 0 could be a normal case. Here the invalid test is for negative coverage.

I see. thanks