On 9/20/2025 6:15 AM, Andrii Nakryiko wrote:
On Fri, Sep 5, 2025 at 8:13 AM Xu Kuohai xukuohai@huaweicloud.com wrote:
[...]
-static struct ringbuf_bench *ringbuf_setup_skeleton(void) +static struct ringbuf_bench *ringbuf_setup_skeleton(int bench_prod)
int because C doesn't support bool?...
No special reason, just wrote it like that. I’ll switch it to bool
but really, do we need another benchmark just to set overwritable mode?... can't you adapt existing benchmarks to optionally set overwritable mode?
OK, I’ll adapt the existing benchmarks to support it.
(and please drop sdf@google.com from CC for the next revision, that email doesn't exist anymore)
OK
[...]