On Sat, Oct 18, 2025 at 03:36:20PM -0700, Vipin Sharma wrote:
Having __packed in my version of struct, I can build validation like hardcoded offset of members. I can add version number (not added in this series) for checking compatbility in the struct for serialization and deserialization. Overall, it is providing some freedom to how to pass data to next kernel without changing or modifying the PCI state structs.
I keep saying this, and this series really strongly shows why, we need to have a dedicated header directroy for LUO "ABI" structs. Putting this random struct in some random header and then declaring it is part of the luo ABI is really bad.
All the information in the abi headers needs to have detailed comments explaining what it is and so on so people can evaluate if it is suitable or not.
But, it is also not clear why pci serialization structs should leak out of the PCI layer.
The design of luo was to allow each layer to contribute its own tags/etc to the serialization so there is no reason to have vfio piggback on pci structs or something.
Jason