Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

On Mon, Jun 16, 2025 at 05:26:18PM -0700, Andrew Morton wrote:

On Mon, 16 Jun 2025 15:34:06 +0530 Ujwal Kundur ujwal.kundur@gmail.com wrote:

...

Refactor macros and non-composite global variable definitions into a struct that is defined at the start of a test and is passed around instead of relying on global vars.

Well I guess that's nicer.

...

5 files changed, 616 insertions(+), 542 deletions(-)

It needs to be!

Thanks, I'll queue it for testing while Peter thinks about it :)

I didn't pay much attention on this one as I saw Brandan was actively reviewing it, which was great.

This is definitely an improvement to the test. Thanks both!