Re: [PATCH v1 1/3] selftests/mm: factor out detection of hugetlb page sizes into vm_util

On 28.05.23 16:49, Lorenzo Stoakes wrote:

On Fri, May 19, 2023 at 12:27:21PM +0200, David Hildenbrand wrote:

...

Let's factor detection out into vm_util, to be reused by a new test.

Bit of a nit as it's hardly vitally important, but perhaps worth mentioning that you also refactor the function to accept any array (this is a requirement rather than simply refactoring a thing but still :)

Well, the function used to, and still does accept an array. It's just a more human-friendly way of expressing that.

If I have to resend the whole patchset, I can add a note "While at it, make the function accept an array instead of a raw pointer.".

[...]

Looks good to me,

Reviewed-by: Lorenzo Stoakes lstoakes@gmail.com

Thanks!