Re: [PATCH] selftests: drivers/s390x: Use SKIP() during FIXTURE_SETUP

On 5/18/24 02:18, Kees Cook wrote:

Instead of mixing selftest harness and ksft helpers, perform SKIP testing from the FIXTURE_SETUPs. This also means TEST_HARNESS_MAIN does not need to be open-coded.

Signed-off-by: Kees Cook keescook@chromium.org

Adding the author in CC.

This changes the skip behavior from one single skip to a skip per test. Not an issue, but a change.

But also we're generating invalid TAP AFAIK which we also have been before but we can fix that in this patch.

From what I understand this line should have a "#" prefix to show that it's a comment: Enable CONFIG_S390_UV_UAPI and check the access rights on /dev/uv.