On Wed, Apr 23, 2025 at 04:16:12PM -0700, Jakub Kicinski wrote:
On Fri, 18 Apr 2025 01:37:05 +0000 Joe Damato wrote:
- bin_remote = cfg.remote.deploy(cfg.test_dir / "napi_id_helper")
- listen_cmd = f"{bin_remote} {cfg.addr_v['4']} {port}"
- with bkg(listen_cmd, ksft_wait=3) as server:
Sorry, not sure how I misread v2 but you are running the helper locally. So you don't have to deploy it to the remote machine :(
OK I can remove that and fix the macro guard for the v4.
BTW does removing the ksft_wait() from the binary work? Or does it cause trouble? Don't think we need to wait for anything in this case. With the XSK test we had to wait for the test to do the inspection before we unbound. Here once we get the connection we can just exit, no?
I agree that we can just exit, but removing the wait breaks ksft utils:
# Exception| Traceback (most recent call last): # Exception| File "/home/jdamato/code/net-next/tools/testing/selftests/net/lib/py/ksft.py", line 223, in ksft_run # Exception| case(*args) # Exception| File "/home/jdamato/code/net-next/./tools/testing/selftests/drivers/net/napi_id.py", line 13, in test_napi_id # Exception| with bkg(listen_cmd, ksft_wait=3) as server: # Exception| File "/home/jdamato/code/net-next/tools/testing/selftests/net/lib/py/utils.py", line 130, in __exit__ # Exception| return self.process(terminate=self.terminate, fail=self.check_fail) # Exception| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ # Exception| File "/home/jdamato/code/net-next/tools/testing/selftests/net/lib/py/utils.py", line 78, in process # Exception| os.write(self.ksft_term_fd, b"1") # Exception| BrokenPipeError: [Errno 32] Broken pipe
LMK how you'd like me to proceed ?
I'm thinking: - Leave ksft_wait() - macro guard - don't deploy helper to remote machine