Re: [PATCH bpf-next 1/2] bpf: helpers: fix bpf_wq_set_callback_impl signature

On Fri, 2024-07-05 at 15:44 +0200, Benjamin Tissoires wrote:

I realized this while having a map containing both a struct bpf_timer and a struct bpf_wq: the third argument provided to the bpf_wq callback is not the struct bpf_wq pointer itself, but the pointer to the value in the map.

Which means that the users need to double cast the provided "value" as this is not a struct bpf_wq *.

This is a change of API, but there doesn't seem to be much users of bpf_wq right now, so we should be able to go with this right now.

Fixes: 81f1d7a583fa ("bpf: wq: add bpf_wq_set_callback_impl") Signed-off-by: Benjamin Tissoires bentiss@kernel.org

---

Reviewed-by: Eduard Zingerman eddyz87@gmail.com