Re: [PATCH net-next v5 03/12] selftests: ncdevmem: Unify error handling

On 10/29, Jakub Kicinski wrote:

On Wed, 23 Oct 2024 08:43:53 -0700 Stanislav Fomichev wrote:

...

ret = inet_pton(server_sin.sin_family, server_ip, &server_sin.sin_addr);

• if (socket < 0)

• error(79, 0, "%s: [FAIL, create socket]\n", TEST_PREFIX);
  

• if (ret < 0)

• error(1, pton, "%s: [FAIL, create socket]\n", TEST_PREFIX);
  

Looks like sched_ext broke our build_tools check, I think I pushed a fix, but I also see here:

ncdevmem.c: In function ‘do_server’: ncdevmem.c:343:26: error: ‘pton’ undeclared (first use in this function) 343 | error(1, pton, "%s: [FAIL, create socket]\n", TEST_PREFIX); | ^~~~ -- pw-bot: cr

Oh, thanks, will double check. This looks silly.