On Mon, 10 Jul 2023 18:53:53 +0000 Ajay Kaher akaher@vmware.com wrote:
Something was broken in your mail (I guess cc list) and couldn’t reach to lkml or ignored by lkml. I just wanted to track the auto test results from linux-kselftest.
Below is the report from the tree I pushed. I guess I forgot to remove an "idx" variable, and it also caught the unused functions you mentioned.
-- Steve
tree: git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace trace/rfc/eventfs head: 1dc48374bb8ad8aec6d7244267f9b36e0512d3bb commit: 1dc48374bb8ad8aec6d7244267f9b36e0512d3bb [28/28] tracefs: Add RCU and global mutex for eventfs config: x86_64-kexec (https://download.01.org/0day-ci/archive/20230711/202307111415.tc8g7M63-lkp@i...) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230711/202307111415.tc8g7M63-lkp@i...)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot lkp@intel.com | Closes: https://lore.kernel.org/oe-kbuild-all/202307111415.tc8g7M63-lkp@intel.com/
All warnings (new ones prefixed by >>):
fs/tracefs/event_inode.c: In function 'eventfs_post_create_dir':
fs/tracefs/event_inode.c:236:13: warning: unused variable 'idx' [-Wunused-variable]
236 | int idx; | ^~~ fs/tracefs/event_inode.c: At top level: fs/tracefs/event_inode.c:184:23: warning: 'eventfs_create_dir' defined but not used [-Wunused-function] 184 | static struct dentry *eventfs_create_dir(const char *name, umode_t mode, | ^~~~~~~~~~~~~~~~~~ fs/tracefs/event_inode.c:108:23: warning: 'eventfs_create_file' defined but not used [-Wunused-function] 108 | static struct dentry *eventfs_create_file(const char *name, umode_t mode, | ^~~~~~~~~~~~~~~~~~~
vim +/idx +236 fs/tracefs/event_inode.c
225 226 /** 227 * eventfs_post_create_dir - post create dir routine 228 * @ef: eventfs_file of recently created dir 229 * 230 * Files with-in eventfs dir should know dentry of parent dir 231 */ 232 static void eventfs_post_create_dir(struct eventfs_file *ef) 233 { 234 struct eventfs_file *ef_child; 235 struct tracefs_inode *ti;
236 int idx;
237 238 /* srcu lock already held */ 239 /* fill parent-child relation */ 240 list_for_each_entry_srcu(ef_child, &ef->ei->e_top_files, list, 241 srcu_read_lock_held(&eventfs_srcu)) { 242 ef_child->d_parent = ef->dentry; 243 } 244 245 ti = get_tracefs(ef->dentry->d_inode); 246 ti->private = ef->ei; 247 } 248