hi Pedro,
On Tue, Jan 23, 2024 at 1:28 PM Pedro Tammela pctammela@mojatatu.com wrote:
If 'jq' is not available the taprio tests that use this script will run forever. Check if it exists before entering the while loop.
Signed-off-by: Pedro Tammela pctammela@mojatatu.com
.../selftests/tc-testing/scripts/taprio_wait_for_admin.sh | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/tc-testing/scripts/taprio_wait_for_admin.sh b/tools/testing/selftests/tc-testing/scripts/taprio_wait_for_admin.sh index f5335e8ad6b4..68f2c6eaa802 100755 --- a/tools/testing/selftests/tc-testing/scripts/taprio_wait_for_admin.sh +++ b/tools/testing/selftests/tc-testing/scripts/taprio_wait_for_admin.sh @@ -3,6 +3,11 @@ TC="$1"; shift ETH="$1"; shift
+if ! command -v jq &> /dev/null; then
- echo "Please install jq"
- exit 1
+fi
nit: what about returning $KSFT_SKIP (that is 4) if jq is not there? so the test does not fail. thanks!